Conversation
- Agent counts came from n_* scenario columns the PDL does not contain. setup_agents(1) now populates one agent per roster entry. - The pooled eu_farmers list splits into poultry_farms, pig_farms and dairy_farms, named after their entity ids like producers and wholesalers - _step_consumer divided trader feed by the agents in its own list, derived from the foster. - shock_ramp_steps is deleted alongside the eight n_* columns - wholesaler economics untouched
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The critical one-entity/one-agent roster binding issue remains unresolved; the README also needs a schema-name correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Refactors agent counts to derive one agent per PDL entity and splits EU consumers into separate rosters.
Changes:
- Removes invented count fields and CSV columns.
- Updates topology, consumer feed allocation, tests, fixtures, and documentation.
- Review notes identify a roster-binding issue in
model.pyand an outdated README output name.
| File | Summary |
|---|---|
tests/test_transport_routing.py |
Updates transport routing coverage. |
tests/test_topology_snapshot.py |
Removes count metadata assertions. |
tests/test_topology_export_contract.py |
Validates split consumer nodes and edges. |
tests/fixtures/topology_snapshot_23.py |
Refreshes roster and adjacency fixtures. |
src/provider_simenv/topology.py |
Removes count metadata and splits consumer rosters. |
src/provider_simenv/scenario.py |
Removes population-count parameters. |
src/provider_simenv/model.py |
Initializes roster agents; fixed-name entities may still be grouped incorrectly. |
src/provider_simenv/data/input/SimulatorScenarios.csv |
Removes count columns. |
src/provider_simenv/data/input/SimulatorScenarios_template.csv |
Updates the scenario schema. |
src/provider_simenv/agents/farmer.py |
Shares feed across active consumers. |
README.md |
Documents PDL-derived counts; one output name remains outdated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| arc = entry.archetype | ||
| agent_list = getattr(self, arc.name) | ||
| agent_list.setup_agents(getattr(self.scenario, arc.count_attr)) | ||
| agent_list.setup_agents(1) |
Comment on lines
+150
to
+151
| Each row is one run. Columns are engine parameters (routing, size sigmas, storage, length). | ||
| Agent counts are not CSV columns — the roster derives one agent per PDL entity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 — PDL-literal agent counts (n=1) and consumer split
One PDL entity is now one agent. The n_* count columns are gone from scenario.py and both scenario CSVs, count_attr is gone from topology.py and model.py, and the pooled eu_farmers list is split into poultry_farms, pig_farms and dairy_farms: three roster entries named after their entity ids, exactly like producers and wholesalers. Wholesaler economics are untouched.
Scenario 0, final period
Findings
_step_consumerdivided the traders' feed by the agents in its own list, which after the split would have delivered three times the feed produced.Follow-ups being filed
SEA_CAPACITY,base_yieldand thefixed_costs_*are calibrated against agent counts that no longer exist.livestock_pressuredeclares supply −9% / price +20% onpoultry_farms), and the feed share assumes all consumers share one upstream.